-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add invalid struct error #238
Conversation
Co-authored-by: Tom Fox <[email protected]>
Co-authored-by: Corey <[email protected]>
Co-authored-by: Corey <[email protected]>
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 76.72% 76.70% -0.02%
==========================================
Files 99 99
Lines 10374 10382 +8
==========================================
+ Hits 7959 7964 +5
- Misses 2415 2418 +3
Continue to review full report at Codecov.
|
It also looks like you broke some Linux tests as well. Those will need to be fixed before the PR can be approved. |
The test that is failing on Linux is the one that I added (the different response for the .invalidStruct error). Does linux handle swift json decoding differently? |
Yes, there are some differences with key order and it's possible linux throws a different NSError as the error code you are using might come from obj-c. If you want to see the exact error code, you probably will need to add a print statement and then check the linux CI for the value of the code |
Let me know if you need any help with finishing this. After this PR is merged, I'll release a new version. |
Sorry I’ll try wrap this up today! |
@dblythy Will this also show better error logging for when a certain key that is required in the database isn't filled in? |
Still testing locally to make sure this doesn't clash with other error codes |
@novemTeam I'm not sure to be honest, what error do you currently get when that happens? |
New Pull Request Checklist
Issue Description
Invalid structs are really hard to isolate the cause of the problem, especially with larger classes
Related issue: #237
Approach
Checks if error code is
4865
and returns error .invalidStruct if soTODOs before merging