Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LiveQuery module to SDK #1712
feat: Add LiveQuery module to SDK #1712
Changes from 14 commits
132a8d1
b3c945c
4728be4
f7405fc
a33ca50
7656ec8
24bfff1
ab190eb
4f80d5c
07836f0
de5b6c7
56f90c8
5a4b32f
2eea533
1f02173
abd8feb
413aec7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change and is this a breaking change?
It seems a bit odd to name the core module
Parse
, as the term "Parse" is arguably referring to the whole SDK. To me is makes more sense to name the core moduleParseCore
to indicate that it's the basis that is always needed, while others are optional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, yes it is an important change because in SDK target has the name "Parse". When we set "ParseCore" it causes an error downloading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand. Why can't we keep the name
ParseCore
? I mean this is only an issue for the LiveQuery module, right? Otherwise we make a breaking change because developers changed their imports fromParse
toParseCore
with the introduction of SPM, and now we are changing it back toParse
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtrezza This is my first time using SPM and I didn't know you had to do
import ParseCore;
. I can try to revert it back and fix the downloading error. @vazarkevych Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vazarkevych Could you take a look at this so we can close this PR? It seems to be the last remaining issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtrezza Can you commit 1 example of tedious work? I'll finish the rest. I don't quite understand what needs to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1712 (comment). The module name
ParseCore
shouldn't change, just because we're adding the LiveQuery module in this PR. Otherwise this PR becomes a breaking change, but it's just a feature addition.So I'd simply remove the renaming and then go into the LiveQuery module and make sure it uses the
ParseCore
reference. It seems the issue is that the LiveQuery module is looking for the Parse module by using its oldParse
reference instead of theParseCore
reference in this repository. To me this looks like a simple find/replace task and some manual correction.This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dplewis Do you want to take a look at this, we could add an additional bounty.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.