Bandaid for empty operationSetQueue during _mergeAfterSaveWithResult: #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
approved these changes
Dec 10, 2018
|
Thanks for the PR! This is not perfect, but good enough for me now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in the wild: many repeated crashes, by just a few users, where
_mergeAfterSaveWithResultcrashes due tooperationSetQueuebeing empty and assuming that it has at least one item to pop.No idea what triggers it.
Band-aid: pre-check and, if the queue is empty at this point, add a dummy empty
PFOperationSet.Results: that particular crash no longer appears in our Crashlytics reports. Whether the people in question are now having other difficulties, we don't know. This is obviously a state that shouldn't be reached in the first place, so the band-aid is covering a deeper problem.
ref issue #1262