Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Swift Package Manager support; upgrade ParseFacbookUtils to Facebook SDK 15 #1683

Merged
merged 25 commits into from
Jan 29, 2023
Merged

feat: Add Swift Package Manager support; upgrade ParseFacbookUtils to Facebook SDK 15 #1683

merged 25 commits into from
Jan 29, 2023

Conversation

vazarkevych
Copy link
Contributor

@vazarkevych vazarkevych commented Nov 28, 2022 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

Closes: #1453
Closes: #1635

Approach

Configure Package.swift for release framework with SPM
Updated Facebook SDK to the latest version (15.1.0)

Credits

This PR contains work from @rocxteady’s branch spm, thanks for his contribution!

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 28, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza changed the title WIP: SPM support feat: add Swift Package Manager support Nov 28, 2022
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add Swift Package Manager support feat: Add Swift Package Manager support Nov 28, 2022
@mman
Copy link
Contributor

mman commented Nov 28, 2022

Thanks @vazarkevych for the PR. Since I am the original author of the SPM fork here: https://github.com/mman/Parse-SDK-iOS-OSX/tree/spm (which required tons of changes to make work), I really like your simple approach 👍

Trying to push the limit, is it really necessary to change all the <Parse/ includes? Can't we make it work without that?

@mtrezza
Copy link
Member

mtrezza commented Nov 28, 2022 •
edited
Loading

Trying to push the limit, is it really necessary to change all the <Parse/ includes? Can't we make it work without that?

What would be the pro of avoiding that?

@mman
Copy link
Contributor

mman commented Nov 28, 2022

@mtrezza I think keeping the #include <Parse/….> follows the general pattern used by framework includes on Apple platforms, that is all…

@mtrezza
Copy link
Member

mtrezza commented Nov 28, 2022

Got it, thanks for clarifying

@vazarkevych
Copy link
Contributor Author

Thanks @vazarkevych for the PR. Since I am the original author of the SPM fork here: https://github.com/mman/Parse-SDK-iOS-OSX/tree/spm (which required tons of changes to make work), I really like your simple approach 👍

Trying to push the limit, is it really necessary to change all the <Parse/ includes? Can't we make it work without that?

Thank you @mman for your feedback on PR.
Basically, it is necessary to have it, as otherwise, the compiler can't find the proper file

@mtrezza
Copy link
Member

mtrezza commented Nov 30, 2022

@parse-community/ios-sdk anyone who would want to try this branch out and give feedback?

mtrezza
mtrezza requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a general note, the parseUI job is failing, it should be passing:

❌ /Users/runner/work/Parse-SDK-iOS-OSX/Parse-SDK-iOS-OSX/ParseUI/ParseUIDemo/Classes/AppDelegate.m:33:9: 'ParseTwitterUtils.h' file not found
#import "ParseTwitterUtils.h"

mtrezza
mtrezza requested changes Dec 1, 2022
View reviewed changes
Cartfile Outdated Show resolved Hide resolved
@vazarkevych vazarkevych force-pushed the SPM branch 2 times, most recently from 9a85111 to b15d091 Compare December 3, 2022 14:33
@vazarkevych vazarkevych force-pushed the SPM branch 5 times, most recently from e01f01f to 7b8b947 Compare December 5, 2022 08:26
@mtrezza mtrezza closed this Dec 31, 2022
@mtrezza mtrezza reopened this Dec 31, 2022
This was referenced Jan 2, 2023
Closed
Closed
@mtrezza mtrezza changed the title feat: Add Swift Package Manager support feat: Add Swift Package Manager support; remove Carthage support Jan 7, 2023
@mtrezza mtrezza mentioned this pull request Jan 17, 2023
Closed
4 tasks
@mtrezza
Delete .circleci directory
890f72f 
Circle CI is not used anymore
mtrezza
mtrezza previously approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci fails, looking into it...

Suggested changelog entry:

BREAKING CHANGE: Carthage support is removed; the core module name has changed therefore the import statement is now import ParseCore instead of import Parse (#1683)

@mtrezza
Copy link
Member

mtrezza commented Jan 29, 2023 •
edited
Loading

The CI runs on macos_latest for assets. The job fails now because "latest" is macOS 12 where Xcode 11 is no longer installed, min. version is Xcode 13.1, see docs.

Also ruby 3 is the default on the macOS 12 image, so we have to explicitly add a ruby setup to CI workflow to install ruby 2.

If assets don't build with Xcode 13 then the CI can pin to the macOS 11 image temporarily.

@mtrezza mtrezza changed the title feat: Add Swift Package Manager support; remove Carthage support feat: Add Swift Package Manager support; upgrade ParseFacbookUtils to Facebook SDK 15 Jan 29, 2023
@mtrezza mtrezza merged commit 840390b into parse-community:master Jan 29, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 29, 2023
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
96fb3ad 
# [2.0.0](1.19.4...2.0.0) (2023-01-29)

### Features

* Add Swift Package Manager support; upgrade `ParseFacbookUtils` to Facebook SDK 15 ([#1683](#1683)) ([840390b](840390b))

### BREAKING CHANGES

* Carthage support is removed; the core module name has changed therefore the import statement is now `import ParseCore` instead of `import Parse` (#1683) ([840390b](840390b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 29, 2023
This was referenced Jan 30, 2023
Closed
Closed
Closed
@dplewis dplewis mentioned this pull request Mar 6, 2023
Merged
2 tasks
@santiagoprieto
Copy link

Do you guys know the reason this 2.0.0 release and all newer ones are not showing up in CocoaPods?

@mtrezza
Copy link
Member

mtrezza commented Mar 11, 2023

Cocoapods and carthage support has been removed in favor of SPM support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VolodyaNazarkevych VolodyaNazarkevych VolodyaNazarkevych left review comments

@cbaker6 cbaker6 cbaker6 left review comments

@mtrezza mtrezza mtrezza left review comments

Assignees
No one assigned
Labels
state:breaking state:released Released as stable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Facebook SDK to latest version Support Swift Package Manager
7 participants
@vazarkevych @mman @mtrezza @parseplatformorg @santiagoprieto @cbaker6 @VolodyaNazarkevych