update ci for update carthage

parse-community · Dec 3, 2022 · bb8bb39 · bb8bb39
1 parent 02fb65a
commit bb8bb39
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -135,10 +135,11 @@ jobs:
         sudo gem install bundler
         bundle config set path 'vendor/bundle'
         bundle install
+        carthage update --use-xcframeworks
     - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:parseui:all
       env:
         DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
+      run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:parseui:all
     - name: Send codecov
       run: bash <(curl https://codecov.io/bash)
 

diff --git a/Rakefile b/Rakefile
@@ -558,7 +558,6 @@ namespace :test do
 
   namespace :parseui do
     task :all do
-      Rake::Task['test:parseui:build_carthage'].invoke
       Rake::Task['test:parseui:framework'].invoke
       Rake::Task['test:parseui:demo_objc'].invoke
     end
@@ -584,13 +583,6 @@ namespace :test do
       end
     end
 
-    task :build_carthage do |_|
-      if !system('carthage update facebook-ios-sdk --use-xcframeworks')
-        puts 'Carthage Tests Failed!'
-        exit(1)
-      end
-    end
-
     task :demo_objc do
       task = XCTask::BuildTask.new do |t|
         t.directory = script_folder