Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-automation #1628

Closed
3 tasks done
mtrezza opened this issue Nov 12, 2021 · 23 comments · Fixed by #1632
Closed
3 tasks done

Add release-automation #1628

mtrezza opened this issue Nov 12, 2021 · 23 comments · Fixed by #1632
Labels
type:ci CI related issue

Comments

@mtrezza
Copy link
Member

mtrezza commented Nov 12, 2021

New Feature / Enhancement Checklist

Current Limitation

Releases are still done manually.

Feature / Enhancement Description

Add release automation.

Example Use Case

n/a

Alternatives / Workarounds

Manual release

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 12, 2021

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added the type:ci CI related issue label Nov 12, 2021
@mtrezza
Copy link
Member Author

mtrezza commented Nov 12, 2021

@drdaz I haven't done a release in this repo yet, could you describe the manual process currently, so we can see how to automate these steps?

@drdaz
Copy link
Member

drdaz commented Nov 15, 2021

Sure.

  • Make a release branch + PR
  • Update version numbers: bundle exec rake package:set_version\[X.X.X\]
  • Update Changelog
  • Tag release & push tag
  • Add notes to releases page on GitHub

I... I think that's it. Often the LiveQuery lib needs it's podfile updating too.

@mtrezza
Copy link
Member Author

mtrezza commented Nov 16, 2021

Thanks! So all the version numbers are updated with that single command? That means that aside from the changelog there are no manual edits, correct?

Often the LiveQuery lib needs it's podfile updating too.

What are these updates?

@drdaz
Copy link
Member

drdaz commented Nov 16, 2021

Thanks! So all the version numbers are updated with that single command? That means that aside from the changelog there are no manual edits, correct?

Generally yeah, assuming no last-minute tweaks. I usually dump the root folder in VSCode and search for the old version number after the script is run, just to make sure.

Often the LiveQuery lib needs its podfile updating too.

What are these updates?

The version number of the Parse iOS SDK library in the podfile typically. Cocoapods often wants to select the previous version (even though it's specced using ~> notation).

EDIT: So that notation looks like it only keeps up with patch updates, not minor. So we probably lose the connection when we update the minor version in this repo.

@mtrezza
Copy link
Member Author

mtrezza commented Nov 16, 2021

Got it, I think we can make a script that updates all the version numbers and we should be good. Maybe @cbaker6 also has some input here?

@drdaz
Copy link
Member

drdaz commented Nov 19, 2021

Is this a thing that's happening Really Soon™️? Or should I manually create this release? 🙂

@mtrezza
Copy link
Member Author

mtrezza commented Nov 19, 2021

I'm looking into auto-release over the next days. If you need it urgently, I can manually release.

@mtrezza mtrezza mentioned this issue Nov 21, 2021
2 tasks
@mtrezza
Copy link
Member Author

mtrezza commented Nov 21, 2021

@drdaz I see that you are an owner on cocoapods. Could you add a new owner to there? I would send you the email via Slack if you are there.

@drdaz
Copy link
Member

drdaz commented Nov 21, 2021

@mtrezza I can give it a shot, but I can't get into Slack. The 2FA emails just aren't getting to me 🤔

Any other channels?

@mtrezza
Copy link
Member Author

mtrezza commented Nov 21, 2021

I think it would be good to get you on Slack somehow if that's possible. The release automation PR is ready and it would be good if you could stand-by on Slack for merging, in case there are any glitches. We may have to un-publish from cocoapods if things go wrong. It worked locally but you never know.

@drdaz
Copy link
Member

drdaz commented Nov 21, 2021

There's an invite elsewhere I've clicked on. I'm sure I've been in there before.

The auth just isn't working right now I think.

@mtrezza
Copy link
Member Author

mtrezza commented Nov 21, 2021

I don't think there's a publicly available Slack invite at the moment, they usually expire, so invite is only on a per-user basis now. You can try this link: https://join.slack.com/t/parseopensource/shared_invite/zt-8w385vtf-gIxfSqORSyoK6RO~y3bHZA

@drdaz
Copy link
Member

drdaz commented Nov 21, 2021

That worked. And I've added that email you shared as an owner on the Pod.

@mtrezza
Copy link
Member Author

mtrezza commented Nov 21, 2021

Thanks, it worked indeed

@mtrezza mtrezza linked a pull request Nov 21, 2021 that will close this issue
2 tasks
@cbaker6
Copy link
Contributor

cbaker6 commented Nov 21, 2021

The assets I added back in releases starting from 1.19.2 are missing from the auto-release:

1.19.3

image

1.19.2

image

@mtrezza
Copy link
Member Author

mtrezza commented Nov 21, 2021

they are currently being compiled

@mtrezza
Copy link
Member Author

mtrezza commented Nov 21, 2021

Re-opening, as we need to verify the assets and pods were built correctly before closing this.

@cbaker6 @drdaz could you take a look whether the GitHub release assets and the cocoapods (still building) are fine?

@mtrezza mtrezza reopened this Nov 21, 2021
@cbaker6
Copy link
Contributor

cbaker6 commented Nov 21, 2021

I see the assets showing up. Just a long build I guess.

@mtrezza
Copy link
Member Author

mtrezza commented Nov 21, 2021

Yes, it takes about 25 minutes before the assets are added to the release.

@cbaker6
Copy link
Contributor

cbaker6 commented Nov 21, 2021

I left this comment to speed up the cocoa pod release: #1632 (comment)

@mtrezza mtrezza pinned this issue Nov 21, 2021
@mtrezza mtrezza unpinned this issue Jan 20, 2022
@dplewis
Copy link
Member

dplewis commented Oct 6, 2023

@mtrezza Can we close this? I found that assets comment you where talking about #1628 (comment)

@mtrezza
Copy link
Member Author

mtrezza commented Oct 6, 2023

Yes, I believe so; thanks

@mtrezza mtrezza closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci CI related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants