Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #992 #999

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Fix #992 #999

merged 2 commits into from
Nov 14, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Nov 14, 2019

Revert #978

user.constructor.name === 'ParseUser' would never be true in minimized code as ParseUser wouldn't exist (because it is minimized to a variable)

Revert #978
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #999 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files          53       53           
  Lines        5094     5094           
  Branches     1145     1145           
=======================================
  Hits         4682     4682           
  Misses        412      412
Impacted Files Coverage Δ
src/ParseUser.js 82.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a66086...6aaf708. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dplewis dplewis merged commit 6ef0a4b into master Nov 14, 2019
@dplewis dplewis deleted the fix-992 branch November 14, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants