Reuse StorageController for LDS

[dplewis]

Can be useful for #967

• Reduces the number of test and files.

Let me know if changes are needed.

Some of the promises could be written better.

[codecov]

Codecov Report

Merging #984 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage   91.86%   91.87%   +0.01%     
==========================================
  Files          54       53       -1     
  Lines        5086     5073      -13     
  Branches     1147     1144       -3     
==========================================
- Hits         4672     4661      -11     
+ Misses        414      412       -2

Impacted Files	Coverage Δ
src/CoreManager.js	100% <ø> (ø)	⬆️
src/StorageController.default.js	100% <100%> (ø)	⬆️
src/Storage.js	95.31% <100%> (+0.86%)	⬆️
src/LocalDatastore.js	99.13% <100%> (+0.83%)	⬆️
src/StorageController.react-native.js	100% <100%> (ø)	⬆️
src/LocalDatastoreController.react-native.js	100% <100%> (ø)	⬆️
src/StorageController.browser.js	100% <100%> (ø)	⬆️
src/LocalDatastoreController.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42cd14...7620752. Read the comment docs.

[acinader]

looks good to me!

see notes.

[acinader]

lgtm

[Brokray]

Hello @dplewis,

I just saw you added getAllKeys as a required method for a StorageController, could you explain me why so? Is that intended?

It seems to me that in the definition type of a StorageController there is no getAllKeys method expected.
Which statement should we believe?

Here you can find the change I am talking about.

[dplewis]

That is intended for dumping the LocalDatastore.

If the definition type is missing can you add it?