-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing documentation for Custom Auth #963
Conversation
Closes: #934 Adds deprecation for _linkWith and _loginWith
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
==========================================
- Coverage 91.94% 91.88% -0.06%
==========================================
Files 54 54
Lines 5077 5080 +3
Branches 1142 1143 +1
==========================================
Hits 4668 4668
- Misses 409 412 +3
Continue to review full report at Codecov.
|
@rhuanbarreto Anything you want to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anywhere where a user can find a code example of how to do use an auth adapter? I guess in unit tests -- which is where i figured it out, but i still needed your help :). Would be nice to have a working example somewhere...
There is documentation in the guide Custom Authentication Module. There are some missing documentation in it as well like id field in Working code examples are in ParseUserTest and a working server setup here. |
@acinader Perhaps we should add this to the ReadMe since this highly requested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Yes, I think adding a single sentence with a link in this section: https://github.com/parse-community/parse-dashboard#other-configuration-options in the readme would be a good idea.
-
The guide could use updating to drop the dangling _ (and adding a link to the tests would be a good idea)
this is super nice.
I think that this will help more the people looking for answers and it’s enough for now. I managed to implement the Keycloak login but I’m using the REST API for now. Soon I will try to commit something showing how is it on Server side. |
@rhuanbarreto Having another set of eyes always helps as we tend to forget new users have to read through the documentation. If you can try to use |
Closes: #934
Addresses: #552
Adds deprecation for _linkWith and _loginWith
I can check the links works after this PR is merged.