Support compiling on Windows #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts bash script to node script. No longer requires gulp to be installed globally. Fixes: #925 @JeromeDeLeon Can you test if this works?
Codecov Report
@@ Coverage Diff @@
## master #947 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 54 54
Lines 5045 5045
Branches 1133 1133
=======================================
Hits 4639 4639
Misses 406 406Continue to review full report at Codecov.
|
acinader
approved these changes
Oct 9, 2019
|
I was able to install it successfully. Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts bash script to node script.
No longer requires gulp to be installed globally.
Fixes: #925
Let me know if this can be improved.
@JeromeDeLeon Can you test if this works?