Add master-key-only option when saving config parameter

[mtrezza]

This allows to save a config parameter that can be read with master key only using Parse.Config.save(parameters, masterKeyOnly).

An additional argument can be added to specify which of the parameters should be retrievable with master key only, for example:

Parse.Config.save(
    { internal: "i", public: "p" },
    { internal: true }
 );

A config parameter is retrievable without master key if it is not added in the masterKeyOnly argument or is added with value false.

[codecov]

Codecov Report

Merging #910 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          54       54           
  Lines        5045     5045           
  Branches     1133     1133           
=======================================
  Hits         4639     4639           
  Misses        406      406

Impacted Files	Coverage Δ
src/ParseConfig.js	87.95% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc8da0...1ca0162. Read the comment docs.

[mtrezza]

The code coverage diff seems to be a false positive? The integration tests seem to cover all the changed code.

[dplewis]

I have a few comments and nits

[dplewis]

@mtrezza The code coverage here refers to the unit tests and not the integration tests.

[mtrezza]

What should I do about the decreased coverage? Should I add unit test even though the integration tests cover it already?

Correction: Coverage shows no diff anymore.

[dplewis]

Even tho the coverage is a 100% now. A few unit test is recommended

Add tests here https://github.com/parse-community/Parse-SDK-JS/blob/master/src/__tests__/ParseConfig-test.js#L103

You can check out the ParseObject-test.js

Since you are passing in parameters, you want to check that those parameters get passed into the restController

[mtrezza]

Since you are passing in parameters, you want to check that those parameters get passed into the restController

How would I do this, like this?

it('can save a config object with a parameter that be retrieved with masterkey only', async () => {
    ParseConfig.save(
      {internal: 'i', number: 12},
      {internal: true});
    expect(CoreManager.getRESTController().request.mock.calls[0]).toEqual([
      'PUT',
      'config',
      { params: {internal: 'i', number: 12}, masterKeyOnly: {internal: true} },
      { useMasterKey: true }]);
  });

[dplewis]

There are a few ways, you can do it. (Don't forget to remove fit)

fit('can get a config object with master key', async () => {
    CoreManager.setRESTController({
      request(method, path, body, options) {
        expect(method).toBe('GET');
        expect(path).toBe('config');
        expect(body).toEqual({});
        expect(options).toEqual({ useMasterKey: true });
        return Promise.resolve({
          params: {
            str: 'hello',
            num: 45
          }
        });
      },
      ajax() {}
    });
    const config = await ParseConfig.get({ useMasterKey: true });
    expect(config.get('str')).toBe('hello');
    expect(config.get('num')).toBe(45);
    const path = Storage.generatePath('currentConfig');
    expect(JSON.parse(Storage.getItem(path))).toEqual({
      str: 'hello',
      num: 45,
    });
  });

[mtrezza]

The unit test I added fails because encode results in undefined for all values:

Parse-SDK-JS/src/ParseConfig.js

Lines 190 to 192 in 2fc8da0

	for(const key in attrs){
	encodedAttrs[key] = encode(attrs[key])
	}

Strange, because that logic was not changed in this PR.

[mtrezza]

Amazing! Thanks @dplewis

[mtrezza]

@dplewis Could you do a release so we can close parse-community/parse-server#5930?