Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to get parse config with master key #907

Merged
merged 5 commits into from
Sep 5, 2019

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 4, 2019

Adds support to retrieve the parse config with the master key. Allows to retrieve config parameters that require the master key to be retrieved.

Related to

@mtrezza
Copy link
Member Author

mtrezza commented Sep 4, 2019

Don't merge yet, integration test missing.

How can I add an integration test for getting config parameters that require the master key?
Currently the JS SDK does not support setting a parameter to require the master key. Can I write directly to the DB and flag a parameter to require the master key for a test?

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #907 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #907   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          54       54           
  Lines        5045     5045           
  Branches     1131     1133    +2     
=======================================
  Hits         4639     4639           
  Misses        406      406
Impacted Files Coverage Δ
src/ParseConfig.js 87.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074f651...604f010. Read the comment docs.

@davimacedo
Copy link
Member

You can:

  • test if the rest command is sent correctly when passing the master key option; and
  • add one test to the integration tests in which you could first use a REST API call to create the config and then use the SDK to retrieve the config.

@mtrezza
Copy link
Member Author

mtrezza commented Sep 5, 2019

@davimacedo, the test Parse Config cannot get internal config parameter without masterkey is failing, but locally it passes. Could it be that the tests are not running against parse server 3.8?

@dplewis
Copy link
Member

dplewis commented Sep 5, 2019

@mtrezza If you want to run against the latest commit. Please do the following.

  1. Delete package-lock.json
  2. npm install
  3. Commit new package-lock.json

@dplewis dplewis merged commit 2fc8da0 into parse-community:master Sep 5, 2019
@mtrezza
Copy link
Member Author

mtrezza commented Sep 5, 2019

@dplewis Thanks for cleaning this up so quickly!

@mtrezza mtrezza deleted the add-use-masterkey-to-config branch October 26, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants