Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fetchAllIfNeededWithInclude #900

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Support fetchAllIfNeededWithInclude #900

merged 2 commits into from
Aug 23, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 23, 2019

@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #900 into master will decrease coverage by 0.1%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   92.05%   91.95%   -0.11%     
==========================================
  Files          54       54              
  Lines        5036     5045       +9     
  Branches     1129     1131       +2     
==========================================
+ Hits         4636     4639       +3     
- Misses        400      406       +6
Impacted Files Coverage Δ
src/ParseObject.js 89.42% <62.5%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a397b...8208038. Read the comment docs.

acinader
acinader approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acinader
Copy link
Contributor

can you increase coverage?

@dplewis dplewis merged commit ae5d64a into master Aug 23, 2019
@dplewis dplewis deleted the fetchAllIfNeededWithInclude branch August 23, 2019 20:43
This was referenced Aug 28, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dplewis @acinader