Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testing on Windows #820

Merged
merged 6 commits into from
May 13, 2019
Merged

Support testing on Windows #820

merged 6 commits into from
May 13, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 9, 2019

Closes: #819

  • Add .gitattributes file to default to LF line ending
  • Add cross-env to handle env variables
  • Default watch to browser and added the following commands:

npm run watch:node
npm run watch:browser
npm run watch:react-native

@oallouch Can you try out this branch? I believe with watch, test, and integration should be enough to start contributing.

@dplewis dplewis requested a review from acinader May 9, 2019 16:15
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          54       54           
  Lines        4933     4933           
  Branches     1097     1097           
=======================================
  Hits         4542     4542           
  Misses        391      391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffddb18...2095911. Read the comment docs.

@oallouch
Copy link
Contributor

oallouch commented May 9, 2019

Test and watch work perfectly.
My lib folder gets updated.
ReadPreference, here I come !

@dplewis
Copy link
Member Author

dplewis commented May 9, 2019

@oallouch Glad it worked. Will try to get this in the next release.

@acinader How does this look?

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dplewis dplewis merged commit 2edc162 into master May 13, 2019
@dplewis dplewis deleted the testing-windows branch May 13, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the build system is only for mac/linux, not Windows
3 participants