Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support _linkWith if no provider exists #810

Merged
merged 1 commit into from
May 1, 2019
Merged

Support _linkWith if no provider exists #810

merged 1 commit into from
May 1, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 1, 2019

Closes: #770

Registers a basic auth provider if one doesn't exist.

Users won't have to implement their own Authentication Flow that was required and undocumented before.

Adds test case for linking with twitter

@dplewis dplewis changed the title Support _linkWith if no provider Support _linkWith if no provider exists May 1, 2019
@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #810 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   92.06%   92.07%   +0.01%     
==========================================
  Files          54       54              
  Lines        4925     4933       +8     
  Branches     1096     1097       +1     
==========================================
+ Hits         4534     4542       +8     
  Misses        391      391
Impacted Files Coverage Δ
src/ParseUser.js 82.58% <100%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df81cba...9385390. Read the comment docs.

@dplewis dplewis requested a review from acinader May 1, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Google OAuth login.
2 participants