Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #775 #776

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Fix #775 #776

merged 3 commits into from
Apr 2, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 1, 2019

Closes: #775

Prevent modules from compiling in react-native.

@alioguzhan Can you check if this fix works for you?

Prevent modules from compiling in react-native
@dplewis dplewis requested a review from acinader April 1, 2019 22:17
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions.....

src/ParseFile.js Outdated Show resolved Hide resolved
src/ParseFile.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #776 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          54       54           
  Lines        4903     4903           
  Branches     1088     1088           
=======================================
  Hits         4441     4441           
  Misses        462      462
Impacted Files Coverage Δ
src/ParseFile.js 97.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b14bd5...34db6b8. Read the comment docs.

@alioguzhan
Copy link

Thanks for the quick fix! I will check it today and will let you know. @dplewis

@dplewis dplewis requested a review from acinader April 2, 2019 18:45
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@alioguzhan
Copy link

Sorry @dplewis , I couldn't have the chance to test this fix. But looks fine to me. 👍

@dplewis dplewis merged commit 02366c9 into master Apr 2, 2019
@dplewis dplewis deleted the fix-775 branch April 2, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants