-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to _linkWith(provider) for masterKey #767
Add options to _linkWith(provider) for masterKey #767
Conversation
acinader
commented
Mar 29, 2019
- without the master key it is not possible to link a user with an auth provider in cloud code
- remove a recent addition to pass the sessionToken which was added for anonymous auth, but not necessary and causing problems. Also remove the related test.
Remove test that verifies that session token is added to save options
needed to link in cloud code.
2. add a fixme to add options to unlink too
@dplewis parse-server unit tests, my cloud code unit tests and the specific issue I was having (linking a user to a custom OAuth provider in cloud) all work with these changes, but I want to cover and provide passing tests with the master key and test that throw when there is no master key, but I am having trouble getting it to work. gonna sleep on it. If you see anything obvious or have any guidance, I'm all ears :). |
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
=========================================
+ Coverage 90.37% 90.57% +0.2%
=========================================
Files 54 54
Lines 4905 4903 -2
Branches 1089 1088 -1
=========================================
+ Hits 4433 4441 +8
+ Misses 472 462 -10
Continue to review full report at Codecov.
|
* ⚡️ Release v2.3.1 Bump dev-dependencies * remove vendor folder * revert dev-dep * fix flaky tests * add #767 to changelog