Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add email address for npm #764

Merged
merged 1 commit into from
Mar 27, 2019
Merged

add email address for npm #764

merged 1 commit into from
Mar 27, 2019

Conversation

acinader
Copy link
Contributor

No description provided.

@dplewis
Copy link
Member

dplewis commented Mar 27, 2019

Adding an environment variable $NPM_EMAIL would be easier to maintain.

@acinader
Copy link
Contributor Author

righto.

@acinader
Copy link
Contributor Author

hm. actually. after looking at it, i'm going to disagree. this is public and is not a secret, why the indirection? this way anyone can a) see what it is and b) change it if needed through the pr process....

what do you htink?

@dplewis
Copy link
Member

dplewis commented Mar 27, 2019

Thats what we have in parse-server.

this way anyone can a) see what it is

Without this PR I would have never known the email

change it if needed through the pr process

No PR needed just change it in travis settings.

I'll leave it up to you

@acinader
Copy link
Contributor Author

my point would be that everything that isn't a secret should go through pr so it is visible to the community.

so my take would be that if it aint a secret and needs to be a secret, like publishing tokens and such, it should go through pr and be in a git repo

if you leave it up to me, i'm good as it is.

@acinader
Copy link
Contributor Author

i'll move the parse-server and conform it to the same email address for the forthcoming release too.

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          54       54           
  Lines        4886     4886           
  Branches     1084     1084           
=======================================
  Hits         4414     4414           
  Misses        472      472

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1d570...43bf3b6. Read the comment docs.

@acinader acinader merged commit 45658b9 into master Mar 27, 2019
@acinader acinader deleted the add-email-to-npm-travis branch March 27, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants