Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserSubclass.logIn and UserSubclass.signUp returns subclass #756

Merged
merged 2 commits into from
Mar 21, 2019
Merged

UserSubclass.logIn and UserSubclass.signUp returns subclass #756

merged 2 commits into from
Mar 21, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 21, 2019

Closes: #263

Let me know if anything should be added

@dplewis dplewis requested a review from acinader March 21, 2019 18:51
acinader
acinader suggested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you test the static methods too please?

@codecov
Copy link

codecov bot commented Mar 21, 2019 •
edited
Loading

Codecov Report

Merging #756 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files          54       54           
  Lines        4676     4676           
  Branches     1076     1076           
=======================================
  Hits         4207     4207           
  Misses        469      469
Impacted Files Coverage Δ
src/ParseUser.js 79.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d6182...840fc30. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Mar 21, 2019

Oops :)

@dplewis dplewis requested a review from acinader March 21, 2019 19:14
acinader
acinader approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hot. nice polish!

@dplewis dplewis merged commit aceea03 into parse-community:master Mar 21, 2019
@dplewis dplewis deleted the subclass-user-static branch March 21, 2019 20:14
This was referenced Mar 27, 2019
Closed
Closed
@kzmeyao kzmeyao mentioned this pull request Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dplewis @acinader