Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) regeneratorRuntime is not defined #740

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 21, 2019

Closes: #717

If you are in a project that doesn't have a global regeneratorRuntime defined i.e Browser an error is thrown.

This fix causes babel to use @babel/runtime/regenerator instead of a global variable.

regenerator is used whenever async / generator functions are used

Thanks @agoldis

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #740 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #740   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files          53       53           
  Lines        4584     4584           
  Branches     1064     1064           
=======================================
  Hits         4068     4068           
  Misses        516      516

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6034c04...11ad860. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Feb 22, 2019

@acinader Thanks, we should do another release

@dplewis dplewis merged commit f477ee7 into parse-community:master Feb 22, 2019
@dplewis dplewis deleted the runtime-generator branch February 22, 2019 02:30
@acinader
Copy link
Contributor

Yes. 2.2.1?

@dplewis
Copy link
Member Author

dplewis commented Feb 22, 2019

Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: regeneratorRuntime is not defined
2 participants