Add batchSize to saveAll / destroyAll #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add it to destroyAll too |
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
- Coverage 85.77% 85.75% -0.03%
==========================================
Files 48 48
Lines 3902 3909 +7
Branches 886 890 +4
==========================================
+ Hits 3347 3352 +5
- Misses 555 557 +2
Continue to review full report at Codecov.
|
dplewis
changed the title
flovilmart
approved these changes
Nov 29, 2018
|
@flovilmart Do you know why 20 was the default batchSize? |
|
No idea! Perhaps a sensible default, not to overload their servers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.