-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize sdk #620
Modernize sdk #620
Conversation
flovilmart
commented
Aug 2, 2018
- Removes ParsePromise
- Removes backbone style options
- Updates documentations.
- Replace ParsePromise with native Promise - Removes all compatibility with Backbone style callbacks
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=========================================
+ Coverage 84.57% 84.6% +0.02%
=========================================
Files 48 48
Lines 4039 3851 -188
Branches 911 871 -40
=========================================
- Hits 3416 3258 -158
+ Misses 623 593 -30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I don’t know much about jest.runAllTicks()
, flushingPromises()
, setImmediate
and the such
The problem was that some executions needed to wait till all current blocks pending in the promises should be run. That changes with using JS promises. The Parse Promises would run the continuation blocks immediately if possible. With JS, those blocks are enqueue, therefore, we needed a way to flush the current blocks :) |
Ah makes sense, I learned something new. |
Had to learn it the hard way! |
412d36a
to
3c4efb9
Compare