-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specific keys to be reverted in unsaved objects #565
Allow specific keys to be reverted in unsaved objects #565
Conversation
Can we make this backwards compatible please? Now if no keys are passed the SDK an exception will be thrown. |
@flovilmart I'm getting 584/584 passed on the branch which submitted this PR, is it failing after you attempt a merge with master? |
Contains general cleanup and type fixes.
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 85.69% 85.71% +0.02%
==========================================
Files 48 48
Lines 3880 3886 +6
Branches 882 885 +3
==========================================
+ Hits 3325 3331 +6
Misses 555 555
Continue to review full report at Codecov.
|
LGTM’ thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be issues in the tests / lint. Can you adress those?
@flovilmart should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s go! Thanks for bearing with me on this one. It took a while, but it was worth it I believe!
Currently, the
Parse.Object
prototype methodrevert
resets ALL unsaved changes. With this PR, specific fields can be provided to the function to allow selective reversion.Currently:
With PR (test cases in commit):
Example 1 (single field):
Example 2 (multiple fields):
Example 3 (no fields, works as now):