Add support for providing file upload progress. #373

aaron-blondeau-dose · 2016-11-05T16:42:45Z

It would be very convenient if developers could get progress when uploading a file with Parse.File. The use case would look something like this:

var parseFile = new Parse.File(file.name, file);
parseFile.save({
    progress: (value) => {
        console.log("TODO show progress to user : "+value);
    }
}).then();

See also https://www.parse.com/questions/file-upload-progress-javascript-api

facebook-github-bot · 2016-11-05T16:43:01Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

facebook-github-bot · 2016-11-12T02:41:07Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

doender · 2016-12-20T11:41:16Z

Will this be merged?

tommy-b-10 · 2017-03-14T12:02:59Z

Just wondering when this will be merged?

jcguarinpenaranda · 2017-06-07T06:47:22Z

Please merge this!!

flovilmart · 2017-06-18T01:40:04Z

@aaron-blondeau-dose Thanks for the PR, could you fix the conflicts so we can get that one in for the next release?

flovilmart · 2017-07-23T15:50:14Z

@aaron-blondeau-dose ping?

flovilmart · 2018-07-26T11:06:12Z

@aaron-blondeau-dose I'm doing some cleanup here, it seems that it diverged a lot since your PR, are you still interested at getting this one in?

dplewis · 2018-11-30T19:31:21Z

@flovilmart I can help out with this

codecov · 2018-11-30T22:03:15Z

Codecov Report

Merging #373 into master will decrease coverage by 0.13%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   85.82%   85.69%   -0.14%     
==========================================
  Files          48       48              
  Lines        3915     3928      +13     
  Branches      892      898       +6     
==========================================
+ Hits         3360     3366       +6     
- Misses        555      562       +7

Impacted Files	Coverage Δ
src/ParseFile.js	`95.23% <100%> (+0.95%)`	⬆️
src/RESTController.js	`80.71% <35.29%> (-4.33%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686ce43...82970fb. Read the comment docs.

dplewis · 2018-11-30T22:38:46Z

@flovilmart @acinader Quick update on this.

This will only work in the browser. I haven't tried it on IE8 / IE9.

The xmlhttprequest node package seems to be missing the progress event. I would do a PR to add support for it but it seems like that package isn't well maintained.

https://github.com/driverdan/node-XMLHttpRequest

What do you think?

acinader

this looks good. I think its fine to add for just browser.

acinader · 2018-12-18T16:36:23Z

src/ParseFile.js

+   *  * Valid options are:<ul>
+   *   <li>useMasterKey: In Cloud Code and Node only, causes the Master Key to
+   *     be used for this request.
+   *   <li>progress: Callback for upload progress


should add a note here that progress is only supported in the browser

acinader · 2018-12-18T16:38:45Z

src/__tests__/ParseFile-test.js

@@ -6,17 +6,20 @@
 * LICENSE file in the root directory of this source tree. An additional grant
 * of patent rights can be found in the PATENTS file in the same directory.
 */
-
+/* global File */


what's this?

dplewis · 2018-12-18T16:53:05Z

src/__tests__/ParseFile-test.js

@@ -183,6 +186,22 @@ describe('ParseFile', () => {
    expect(a.equals(b)).toBe(false);
    expect(b.equals(a)).toBe(false);
  });
+
+  it('reports progress during save when source is a File', () => {
+    const file = new ParseFile('progress.txt', new File(["Parse"], "progress.txt"));


@acinader /* global File */ is for the new File(...) so that it can find it.

kartheeknagasuri · 2019-12-02T10:14:24Z

@dplewis
what's the correct usage of progress call back? I am using like this and not getting any progress call back

var parseFile = new Parse.File(file.name, file);
parseFile.save({
progress: (value) => {
console.log("TODO show progress to user : "+value);
}
}).then();

dplewis · 2019-12-02T21:19:44Z

@kartheeknagasuri That is correct. This feature is for the browser only.

kartheeknagasuri · 2019-12-10T13:12:48Z

@dplewis I am trying through the browser, but not getting the call back, not sure what's the problem

ladigitale · 2020-04-01T15:31:57Z

The progress calback seems to be ran just one time with value 1.
I'm trying the upload of files (size about 1Mo) with a slow network in order to follow the evolution

aliasad106 · 2022-08-12T19:01:06Z

Doesn't work, Any progress on this ?

mtrezza · 2022-08-13T00:27:22Z

If there is an issue with this feature, please open a new issue (if it doesn't exist already) to report a bug.

Add support for providing file upload progress.

8f30a88

facebook-github-bot added the CLA Signed label Nov 11, 2016

dplewis added 2 commits November 30, 2018 13:38

Merge branch 'master' into feature/add-file-upload-progress-callback

151bfb9

clean up

196ba8e

dplewis requested review from flovilmart and acinader November 30, 2018 22:50

acinader suggested changes Dec 18, 2018

View reviewed changes

dplewis reviewed Dec 18, 2018

View reviewed changes

dplewis added 2 commits December 18, 2018 10:56

Merge branch 'master' into feature/add-file-upload-progress-callback

058a30b

improve documentation

82970fb

acinader approved these changes Dec 18, 2018

View reviewed changes

dplewis merged commit e66948e into parse-community:master Dec 18, 2018

dplewis mentioned this pull request Feb 5, 2019

Any plans to implement file upload progress? #347

Closed

dplewis mentioned this pull request Sep 11, 2019

file upload progressBar callback parse-community/parse-server-s3-adapter#25

Closed

parse-community locked and limited conversation to collaborators Aug 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for providing file upload progress. #373

Add support for providing file upload progress. #373

aaron-blondeau-dose commented Nov 5, 2016 •

edited

Loading

facebook-github-bot commented Nov 5, 2016

facebook-github-bot commented Nov 12, 2016

doender commented Dec 20, 2016

tommy-b-10 commented Mar 14, 2017

jcguarinpenaranda commented Jun 7, 2017

flovilmart commented Jun 18, 2017

flovilmart commented Jul 23, 2017

flovilmart commented Jul 26, 2018

dplewis commented Nov 30, 2018

codecov bot commented Nov 30, 2018 •

edited

Loading

dplewis commented Nov 30, 2018 •

edited

Loading

acinader left a comment

acinader Dec 18, 2018

acinader Dec 18, 2018

dplewis Dec 18, 2018

kartheeknagasuri commented Dec 2, 2019 •

edited

Loading

dplewis commented Dec 2, 2019

kartheeknagasuri commented Dec 10, 2019

ladigitale commented Apr 1, 2020

aliasad106 commented Aug 12, 2022

mtrezza commented Aug 13, 2022 •

edited

Loading

Add support for providing file upload progress. #373

Add support for providing file upload progress. #373

Conversation

aaron-blondeau-dose commented Nov 5, 2016 • edited Loading

facebook-github-bot commented Nov 5, 2016

facebook-github-bot commented Nov 12, 2016

doender commented Dec 20, 2016

tommy-b-10 commented Mar 14, 2017

jcguarinpenaranda commented Jun 7, 2017

flovilmart commented Jun 18, 2017

flovilmart commented Jul 23, 2017

flovilmart commented Jul 26, 2018

dplewis commented Nov 30, 2018

codecov bot commented Nov 30, 2018 • edited Loading

Codecov Report

dplewis commented Nov 30, 2018 • edited Loading

acinader left a comment

Choose a reason for hiding this comment

acinader Dec 18, 2018

Choose a reason for hiding this comment

acinader Dec 18, 2018

Choose a reason for hiding this comment

dplewis Dec 18, 2018

Choose a reason for hiding this comment

kartheeknagasuri commented Dec 2, 2019 • edited Loading

dplewis commented Dec 2, 2019

kartheeknagasuri commented Dec 10, 2019

ladigitale commented Apr 1, 2020

aliasad106 commented Aug 12, 2022

mtrezza commented Aug 13, 2022 • edited Loading

aaron-blondeau-dose commented Nov 5, 2016 •

edited

Loading

codecov bot commented Nov 30, 2018 •

edited

Loading

dplewis commented Nov 30, 2018 •

edited

Loading

kartheeknagasuri commented Dec 2, 2019 •

edited

Loading

mtrezza commented Aug 13, 2022 •

edited

Loading