-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to interpolate delete operations #289
Adds ability to interpolate delete operations #289
Conversation
Current coverage is 86.58%
@@ master #289 diff @@
==========================================
Files 41 41
Lines 3852 3815 -37
Methods 703 636 -67
Messages 0 0
Branches 837 838 +1
==========================================
- Hits 3336 3303 -33
+ Misses 516 512 -4
Partials 0 0
|
f7afe5c
to
d3ef256
Compare
Greatness |
We could have used null (it works right of the bat) but it's inconsistent with the undefined retuned when key is not set. Also, may cause problems with the iOS SDK as it interpolates to NSNull * and we usually don't love those. |
Shouldn't break things. For compatibility reasons, I might want to bump the version to 1.9.0 for this. |
Also I can't express how happy I am that we're resolving this ridiculous piece of tech debt that has plagued Cloud Code for years 💯 |
That should feel good to say it out loud 👍 |
You can bump to 1.9.0, but it's unlikely that will break backwards. |
Agree it shouldn't break backwards, but I think it'd be easier to say "this functionality is fixed in SDK versions 1.9.0 and up" |
Yup! |
Is there any timing on 1.9.0? |
Sorry @TylerBrock I forgot we were blocking this. I can ship it tomorrow. |
no rush, i was just curious |
I was already intending to ship it this evening, actually, but then I got caught up in investigating the best CDN solution. |
Just released 1.9.0-rc1 as a beta release. |
@TylerBrock turns out I totally f-d up that publish (late night, little sleep). I'm trying to unpublish rc1, but it should all be there under |
On parse.com, when running a beforeSave hook, if a key is
unset
the change is not propagated to the client.On parse-server, we forward this change by setting the
key: {__op: Delete}
that is interpolated by the JS SDK as an UnsetOp.This proposed PR will set key = undefined in those cases fixing parse-community/parse-server#1840
parse-community/parse-server#1946