Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: User management on React-Native #1298

Merged
merged 2 commits into from
Feb 15, 2021
Merged

fix: User management on React-Native #1298

merged 2 commits into from
Feb 15, 2021

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 13, 2021 •
edited
Loading

Closes: #1296

This addresses issues using AsyncStorage.

  • Introduces new user.isCurrentAsync function

@codecov
Copy link

codecov bot commented Feb 13, 2021 •
edited
Loading

Codecov Report

Merging #1298 (b212698) into master (4caede2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines         5800      5808    +8     
  Branches      1305      1306    +1     
=========================================
+ Hits          5800      5808    +8
Impacted Files Coverage Δ
src/ParseUser.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4caede2...b212698. Read the comment docs.

@dplewis dplewis changed the title fix: linkWith on react-native fix: User management on React-Native Feb 13, 2021
davimacedo
davimacedo approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 4b4f3f6 into master Feb 15, 2021
@dplewis dplewis deleted the react-native-linkWith branch February 16, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linkWith() on React Native using currentUser()
2 participants
@dplewis @davimacedo