Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ParseQuery): Select on null fields #1223

Merged
merged 3 commits into from
Sep 17, 2020
Merged

fix(ParseQuery): Select on null fields #1223

merged 3 commits into from
Sep 17, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 12, 2020

Closes: #1196

@codecov
Copy link

codecov bot commented Sep 12, 2020 •
edited
Loading

Codecov Report

Merging #1223 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          54       54           
  Lines        5317     5317           
  Branches     1199     1199           
=======================================
  Hits         4912     4912           
  Misses        405      405
Impacted Files Coverage Δ
src/ParseQuery.js 96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa05044...204d7c6. Read the comment docs.

davimacedo
davimacedo reviewed Sep 17, 2020
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good for me. Just sending a suggestion.

src/ParseQuery.js Outdated Show resolved Hide resolved
@dplewis dplewis requested a review from davimacedo September 17, 2020 17:39
@dplewis dplewis merged commit e2f72c0 into master Sep 17, 2020
@dplewis dplewis deleted the fix-select-null branch September 17, 2020 18:24
@rabidaudio rabidaudio mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza Awaiting requested review from mtrezza

@davimacedo davimacedo Awaiting requested review from davimacedo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queries fail to parse results when asking for subfield of a null pointer or null array of pointers
2 participants
@dplewis @davimacedo