-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata tags #1070
Metadata tags #1070
Conversation
Yes but you are forgetting about fs.chunk and fs.files https://docs.mongodb.com/manual/core/gridfs/
https://mongodb.github.io/node-mongodb-native/3.2/api/GridFSBucket.html#openUploadStream In node you just add an option to I've already tried in the the last metadata PR. |
interesting... at first glance, does this mean files would be stored in the database and not S3? |
I'm sorry by |
So the changes I have in this PR is to get the metadata and tags from the client to the server... the reason I had to convert to base64 is because it was being sent directly through the ajax function as a Buffer of data. There was no way to add additional data to be sent with it. Do you have another suggestion to do this? |
…dk-js into metadata-tags
2b83cf1
to
8496b7c
Compare
@dplewis are there any changes needed for this PR? |
@stevestencil Sorry for the late reply. I have to add a PR to the server repo in order to add test cases for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. I think the build was failing also.
Everything looks good so far
@stevestencil I can have a look at the unit tests if you want. |
@dplewis Feel free! I've been trying to get around to this all week but I have been slammed with work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I’m going to push a release now.
No description provided.