Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix executor for network requests #648

Merged
merged 1 commit into from
Apr 30, 2017

Conversation

natario1
Copy link
Contributor

Fixes #646

@codecov
Copy link

codecov bot commented Apr 29, 2017

Codecov Report

Merging #648 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #648      +/-   ##
============================================
- Coverage     52.88%   52.86%   -0.02%     
  Complexity     1676     1676              
============================================
  Files           131      131              
  Lines         10146    10146              
  Branches       1408     1408              
============================================
- Hits           5366     5364       -2     
- Misses         4338     4339       +1     
- Partials        442      443       +1
Impacted Files Coverage Δ Complexity Δ
Parse/src/main/java/com/parse/ParseRequest.java 82.95% <100%> (ø) 18 <0> (ø) ⬇️
...se/src/main/java/com/parse/ParseKeyValueCache.java 45% <0%> (-2%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032054b...07c1c30. Read the comment docs.

@Jawnnypoo
Copy link
Member

@natario1 Out of curiosity, did you check throughout the rest of the SDK to see if this is happening anywhere else?

@natario1 natario1 mentioned this pull request Apr 30, 2017
@natario1
Copy link
Contributor Author

@Jawnnypoo it looks the only other ExecutorServices are the one in ParseSQLiteDatabase and one in GCMService... but they are both single threaded so there should be no issue

@rogerhu rogerhu merged commit 44eca49 into parse-community:master Apr 30, 2017
@natario1 natario1 deleted the sdk-locking branch April 30, 2017 11:26
@natario1 natario1 mentioned this pull request May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants