Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ParseOkHttpClient #548

Closed
wants to merge 1 commit into from
Closed

Fix bug in ParseOkHttpClient #548

wants to merge 1 commit into from

Conversation

ly85206559
Copy link

ClassCastException happened while delete ParseObject

@facebook-github-bot
Copy link

By analyzing the blame information on this pull request, we identified @rogerhu to be a potential reviewer.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@grantland
Copy link
Contributor

Could you provide more context on the bug you're fixing? Possibly a stack trace or an issue with more information?

@ly85206559
Copy link
Author

: java.lang.ClassCastException: okhttp3.RequestBody$2 cannot be cast to com.parse.ParseOkHttpClient$ParseOkHttpRequestBody
at com.parse.ParseOkHttpClient.getParseHttpRequest(ParseOkHttpClient.java:193)
at com.parse.ParseOkHttpClient.access$000(ParseOkHttpClient.java:39)
at com.parse.ParseOkHttpClient$1.intercept(ParseOkHttpClient.java:214)

and this is Okhttp source code

public Builder delete(RequestBody body) {
  return method("DELETE", body);
}

public Builder delete() {
  return delete(RequestBody.create(null, new byte[0]));
}

so if invoke delete(),RequestBody is created by okhttp, so can't cast to ParseOkHttpRequestBody.

@rogerhu
Copy link
Contributor

rogerhu commented Mar 7, 2017

could use a test but good to go

@rogerhu
Copy link
Contributor

rogerhu commented Mar 8, 2017

On second thought not sure what this fix does since ParseFile doesn't expose a delete...how does this help?

@rogerhu
Copy link
Contributor

rogerhu commented Mar 8, 2017

Going to close until we have more data on what it's supposed to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants