-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in ParseOkHttpClient #548
Conversation
By analyzing the blame information on this pull request, we identified @rogerhu to be a potential reviewer. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Could you provide more context on the bug you're fixing? Possibly a stack trace or an issue with more information? |
: java.lang.ClassCastException: okhttp3.RequestBody$2 cannot be cast to com.parse.ParseOkHttpClient$ParseOkHttpRequestBody and this is Okhttp source code
so if invoke delete(),RequestBody is created by okhttp, so can't cast to ParseOkHttpRequestBody. |
could use a test but good to go |
On second thought not sure what this fix does since ParseFile doesn't expose a delete...how does this help? |
Going to close until we have more data on what it's supposed to fix. |
ClassCastException happened while delete ParseObject