Fix: Multiple "current" ParseInstallation instances being created #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer. |
|
Good catch. But why this race condition will make devieType to be null? |
|
@wangmengyan95 Described in depth here: #203 (comment) Short version is that there could be multiple |
|
LGTM! Thanks for explanation. |
This fixes a race condition where multiple `ParseInstallation` instances can be returned as "current".
grantland
force-pushed
the
grantland.fix-installation
branch
from
e756eab to
fbdffa7
Compare
grantland
added a commit
that referenced
this pull request
Oct 26, 2015
Fix: Multiple "current" ParseInstallation instances being created
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition where multiple
ParseInstallationinstancescan be returned as "current".
Fixes #203