Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype of recording streaming requests #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kpanic
Copy link

@kpanic kpanic commented Jan 4, 2017

Hi @parroty regarding #75
I have sketched this bare bone prototype.
It recorded my responses when using a streamed request, however I would like to hear from you before giving to it another go.

Thanks a lot!

@coveralls
Copy link

coveralls commented Jan 4, 2017

Coverage Status

Coverage decreased (-0.6%) to 93.088% when pulling 3c8ce0f on kpanic:stream-reqs-prototype into 2663050 on parroty:master.

@parroty
Copy link
Owner

parroty commented Jan 6, 2017

Thanks, I wasn't thinking about this approach.
Is it possible for you to write a test for this scenario (or post your example?)

@kpanic
Copy link
Author

kpanic commented Jan 6, 2017

Yes sure, I will try this weekend and try to solve this NOTE https://github.com/parroty/exvcr/pull/85/files#diff-cb27aa72b4049243f7b92ffeaa64c822R67 that I put

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants