Fix ignore localhost when using headers #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the ignore_localhost option when recording requests that send headers. This was raising an ArgumentError because every element of the request was being enumerated and checked as a String (including non-string-like maps, which is how headers are represented). This changes the checking of the url to get the url out of the request via the corresponding adapter.
|
Sorry not responding for a long time. Does merging #140 resolve the issue? |
|
@parroty probably--it looks like a similar fix. I'm not on a project which uses exvcr right now though, so I'm not able to confirm unfortunately. When I have a bit more time later this week I'll try and verify and update this ticket. |
|
Close this as abandoned? |
|
Hi. Are you still observing the issue? I was assuming it was resolved, but didn't have good chance to close this item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ignore_localhost option when recording requests that send
headers. This was raising an ArgumentError because every element of the
request was being enumerated and checked as a String (including
non-string-like maps, which is how headers are represented).
This changes the checking of the url to get the url out of the request
via the corresponding adapter.