Fixing mocked modules coverage handling #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, elixir modules mocked using the meck library may leave a trace in the modules list that
excoveralls
tries to cover which won't have asource
key. As mocks, It is expected that those modules wouldn't have a corresponding source file, butexcoveralls
currently doesn't handle this case. This pull request addresses this issue by improving the bypass logic of modules without a source file.Examples of the return of module_info/1
Unmocked, compiled and executed module
Mocked module
The mocked module scenario starts breaking when whe assume that every module has a
:source
atKeyword.get(info, :source)
. It returnsnil
andhas_compile_info?/1
tries to callFile.exists?/1
withnil
, resulting in the following stacktrace: