Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure due to :connect_timeout from poster #221

Merged

Conversation

pablocostass
Copy link
Contributor

Updated the poster to accept either :timeout or :connect_timeout as a timeout issue (and therefore don't fail the build) and its corresponding test to also mock that case.

@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage remained the same at 89.823% when pulling a1f11a0 on pablocostass:220_dont_fail_on_connect_timeout into 6332f40 on parroty:master.

@parroty parroty merged commit f4660b2 into parroty:master May 26, 2020
@parroty
Copy link
Owner

parroty commented May 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants