Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gulp-compliant source map support #2

Closed
RReverser opened this issue Jul 28, 2014 · 4 comments
Closed

Add gulp-compliant source map support #2

RReverser opened this issue Jul 28, 2014 · 4 comments

Comments

@RReverser
Copy link

pure-cjs returns ready-to-use source map - so why not to add support for it in gulp plugin. Check out how easy it is to implement it at https://github.com/floridoo/gulp-sourcemaps#plugin-developers-only-how-to-add-source-map-support-to-plugins.

@parroit
Copy link
Owner

parroit commented Jul 28, 2014

Very interesting, I will add support to the plugin

@parroit
Copy link
Owner

parroit commented Jul 29, 2014

I added support for sourcemap as you suggested, but there is something wrong in generated sourcemap.
I created an example project. For this example, I get this sourcemap:

{"version":3,"sources":["test/example_test.js.map"], ...

I expect sources to contain "test/example_test.js","lib/example.js", nor the sourcemap file itself.
It's not clear to me if pure is generating it wrong or if it is a fault on my side... could you please give me some help on investigating this issue?

@RReverser
Copy link
Author

Sorry, was my fault. Please update pure-cjs dependency with npm i pure-cjs@* --save.

@parroit
Copy link
Owner

parroit commented Jul 29, 2014

Awesome! Now source mapping works well, thanks

@parroit parroit closed this as completed Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants