Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example in README is broken #1

Closed
RReverser opened this issue Jul 28, 2014 · 3 comments
Closed

Example in README is broken #1

RReverser opened this issue Jul 28, 2014 · 3 comments

Comments

@RReverser
Copy link 

gulp-pure-cjs.awesome(); // "hello "
  1. This wouldn't work as gulp-pure-cjs is not a valid JavaScript identifier.
  2. You would better show how to use plugin with gulp - check out first example in Usage section of https://github.com/wearefractal/gulp-concat.
  3. You have only one option as for now - so why not to provide description for it or at least show how to use it in the same example code.
@RReverser RReverser mentioned this issue Jul 28, 2014
Closed
@parroit
Copy link
Owner

parroit commented Jul 28, 2014

Yes, I have to improve the README, it's just a skeleton by now...

@parroit
Copy link
Owner

parroit commented Jul 28, 2014

I made some improvements on the README, check it when you get some minutes...
Also, I'm thinking on a change and I need your opinion, I created #3

@RReverser
Copy link
Author

README looks ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parroit @RReverser