input: xpad - initialize 360 controllers #120
Conversation
Signed-off-by: Daniel Tobias <[email protected]>
Signed-off-by: Daniel Tobias <[email protected]> Signed-off-by: Jonathan <[email protected]> Signed-off-by: Matt Sturgeon <[email protected]>
Suspending and resuming the system can sometimes cause the out URB to get hung after a reset_resume. This causes LED setting and force feedback to break on resume. To avoid this, just drop the reset_resume callback so the USB core rebinds xpad to the wireless pads on resume if a reset happened. A nice side effect of this change is the LED ring on wireless controllers is now set correctly on system resume. Signed-off-by: Cameron Gutman <[email protected]> Cc: [email protected]
"PDP Wired Controller for Xbox One - Stealth Series | Revenant Blue" see paroj#102
|
It works perfect, thank you very much for fixing it |
Many knockoff brands emulating the XBOX 360 controller do not properly send data unless configured correctly. Examples include the Gamesir G3w and the Fantech GP11 Shooter. Protocol inspection of communication with other operating systems reveals a sequence of control messages that can be used to initialize the controllers sufficiently to send proper data. Proposed-by: Darvin Delgado <[email protected]>
Oblomov
force-pushed
the
init-360-control
branch
from
0f9c476 to
e76539f
Compare
|
Good to know! I've pushed a new version, I had forgotten to free the control message return data in the “no error” path. Hopefully people with an actual XBOX 360 controller or some other knockoff brand can test it to verify that it doesn't break anything for them 8-) |
|
please move your init sequence to Your implementation blocks until all init packets were sent while waiting a magicnumber amount of time. |
|
Hello @paroj, thanks for the hint, I'll rearrange the code per your suggestion. Do I understand correctly that I have to manually encode the USB control request with the approach your propose? |
|
Hm, no, that obviously doesn't work, so I'm guessing I'll have to duplicate what is currently done for the in and out interrupt URBs to add the management and use of a control URB instead … This is starting to get beyond my expertise … |
|
@Oblomov Your patch fixes initialization of Elecom JC-U4013S gamepad. Thanks! |
|
|
||
| status = usb_control_msg(xpad->udev, | ||
| usb_rcvctrlpipe(xpad->udev, 0), | ||
| 0x1, 0xc1, |
There was a problem hiding this comment.
Consider using constants defined in uapi/linux/usb/ch9.h instead of magic values (0x1, 0xc1, etc.)
0x1 = USB_REQ_CLEAR_FETAURE
0xc1 = USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE
0x100 = USB_DEVICE_REMOTE_WAKEUP
FTR: sending just the first packet ( [1] https://xboxdevwiki.net/Xbox_Input_Devices#GET_CAPABILITIES |
|
I am affected by #119 with my Trust GXT 540 Yula controller I just bought: The device will not work in x-input mode unless I use a workaround python script, and unfortunately some games won't work at all on the d-input setting. Is there any news on this pull request please? Any chance we might see the patch in the Linux kernel this year? The last update on this seems to be from two years ago which is concerning. |
|
ok, lets put this to test. Picked manually. |
Many knockoff brands emulating the XBOX 360 controller do not properly
send data unless configured correctly. Examples include the Gamesir G3w
and the Fantech GP11 Shooter.
Protocol inspection of communication with other operating systems
reveals a sequence of control messages that can be used to initialize
the controllers sufficiently to send proper data.
Proposed-by: Darvin Delgado [email protected]