Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New NACON Pro Compact Device ID #284

Closed
ronlaws86 opened this issue Aug 16, 2024 · 5 comments
Closed

New NACON Pro Compact Device ID #284

ronlaws86 opened this issue Aug 16, 2024 · 5 comments

Comments

@ronlaws86
Copy link

ronlaws86 commented Aug 16, 2024

This device isn't picked up by xpad as it has a slight variation in the device ID, I'm guessing a different board revision out in the wild.
lsusb:
ID 3285:0603 NACON Pro Compact
dmesg

[23692.118378] usb 3-8: new full-speed USB device number 28 using xhci_hcd
[23692.245655] usb 3-8: New USB device found, idVendor=3285, idProduct=0603, bcdDevice= 1.01
[23692.245660] usb 3-8: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[23692.245662] usb 3-8: Product: Pro Compact
[23692.245663] usb 3-8: Manufacturer: NACON
[23692.245664] usb 3-8: SerialNumber: 000001016A1505A2
@ronlaws86 ronlaws86 changed the title New NACON Pro Contact Device ID New NACON Pro Compact Device ID Aug 16, 2024
ronlaws86 added a commit to ronlaws86/xpad that referenced this issue Aug 16, 2024
paroj#284
Added Device ID Variant for Nacon Pro Compact
@DJawna
Copy link

DJawna commented Aug 18, 2024

@ronlaws86 the problem is the maintainer of this repo seems to have left the project! i had the same issue like you (i also have a nacon controller that is not in the list of ids) and i solved it by forking the project and adding my nacon controller id myself. you can see it here:
https://github.com/DJawna/xpad

the pr branch i did:
DJawna@21b5c6d

@ronlaws86
Copy link
Author

ronlaws86 commented Aug 20, 2024

@ronlaws86 the problem is the maintainer of this repo seems to have left the project! i had the same issue like you (i also have a nacon controller that is not in the list of ids) and i solved it by forking the project and adding my nacon controller id myself. you can see it here: https://github.com/DJawna/xpad

the pr branch i did: DJawna@21b5c6d

That's basically what I Did in my PR referenced above too. I've got it working, I wonder who's maintaining XPAD now? since it's included in the kernel I think? 🤔

@paroj
Copy link
Owner

paroj commented Aug 20, 2024

I wonder who's maintaining XPAD now?

I still intend to update this repo and merge your changes. I am just short on time right now and will need to first merge back any changes that were done in the kernel version first.

To answer your maintenance question: the xpad driver in the kernel is maintained by the kernel developers and you can send your changes there directly following this guide:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

However, it is not as easy as contributing on github and your changes will only appear in the next kernel release. Hence the purpose of this repo.

@ronlaws86
Copy link
Author

I wonder who's maintaining XPAD now?

I still intend to update this repo and merge your changes. I am just short on time right now and will need to first merge back any changes that were done in the kernel version first.

To answer your maintenance question: the xpad driver in the kernel is maintained by the kernel developers and you can send your changes there directly following this guide: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

However, it is not as easy as contributing on github and your changes will only appear in the next kernel release. Hence the purpose of this repo.

Good to know! I marked my PR as a duplicate and closed it anyway, as it is the same as another PR submitting the same line as someone else 2 or so months ago, it can be safely discarded as it doesn't offer anything more than that one.

@paroj
Copy link
Owner

paroj commented Oct 8, 2024

fixed with #282

@paroj paroj closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants