Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SuperAgent.Header type to http.Header for support multiple values #154

Merged
merged 3 commits into from
Sep 30, 2017
Merged

Change SuperAgent.Header type to http.Header for support multiple values #154

merged 3 commits into from
Sep 30, 2017

Conversation

edentsai
Copy link
Contributor

@edentsai edentsai commented Aug 31, 2017

  1. Change SuperAgent.Header type to http.Header for supports multiple values.
  2. Add AppendHeader() to support multiple values of Header, for example:
// Accept: application/json, text/plain
gorequest.New().
        AppendHeader("Accept", "application/json").
        AppendHeader("Accept", "text/plain").
        Type("text").
        Send("data").
        End()
  1. Add some test cases for force Type().

@edentsai edentsai changed the title Change SuperAgent.Header type to http.Header for consistence Change SuperAgent.Header type to http.Header for support multiple values Aug 31, 2017
@parnurzeal parnurzeal merged commit 2de487b into parnurzeal:develop Sep 30, 2017
@parnurzeal
Copy link
Owner

Thank you for this. Clean and sensible approach.
Also, sorry for the delay reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants