Fix moonbeam chain spec customizations #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
approved these changes
Feb 12, 2025
|
Hi @pepoviola, Do you plan to do a new zombienet release this week? |
Yes, I will release a new version today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The moonbeam customizations were not correct when using
moonbeam-localchain specification. The reason is thatmoonbeamuses a SUPPLY_FACTOR of100, whilemoonbaseandmoonriverhave a supply factor of1. This was causing thereservedBalanceto be incorrect.The fix included in this PR, increases
stakingBondandreservedBalancedefault values to a reasonable amount and overrides the balance of the collator if it is not enough to cover the staking bond and the authoring deposit.