Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstable_rpc: Add transactionBroadcast and transactionStop #1497
unstable_rpc: Add transactionBroadcast and transactionStop #1497
Changes from 5 commits
bdd1e8a
f9283b2
85d6c77
6d3c786
06ae5e2
a211e98
9b29a2e
2155373
b05a938
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the PR to rename to
v1
merged in Substrate already? :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, https://github.com/paritytech/polkadot-sdk/blob/master/substrate/client/rpc-spec-v2/src/transaction/api.rs#L50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this is all good, but if we wanted we could do something like this to avoid relying on any sort of ordering etc:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is just a small inconsistency with this:
compact encoding length
ExtrinsicDetails
will strip the compact prefix:subxt/subxt/src/blocks/extrinsic_types.rs
Line 224 in a211e98
I've adjusted the code to reflect this, not sure if we should do anything else to align for ex with polkadot-api 🤔