This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix compact proof decoding unaccessed last child trie. #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cheme could you maybe add some more tests? And then we can merge this. |
|
Added a small stress test (ran it with more than 50 but it is rather slow). It is not very relevant, but at least it does run on numerous child trie and values. |
cheme
added
B0-silent
bkchr
approved these changes
Sep 7, 2021
arkpar
approved these changes
Sep 7, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
chevdor
pushed a commit
that referenced
this pull request
Sep 8, 2021
* fix no child proof attached but root included. * small stress test for proof of child tries. * rust fmt
ordian
pushed a commit
that referenced
this pull request
Sep 8, 2021
* fix no child proof attached but root included. * small stress test for proof of child tries. * rust fmt Co-authored-by: cheme <[email protected]>
chevdor
added a commit
that referenced
this pull request
Sep 17, 2021
15 tasks
chevdor
added a commit
that referenced
this pull request
Sep 30, 2021
chevdor
added a commit
that referenced
this pull request
Oct 4, 2021
chevdor
added a commit
that referenced
this pull request
Oct 4, 2021
* chore: refresh of the substrate_builder image fix #9715 * chore: renaming + build script * Fix spaces/tabs * Add doc * Remove non binary * Update docker/substrate_builder.Dockerfile Co-authored-by: Denis Pisarev <[email protected]>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while searching for possible issues for paritytech/cumulus#598.
Not sure if it is the actual issue, but it is one.
The case where other child root is included in proof was incorrectly handled when the last child root included was not accessed.