This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add function for embedding the runtime version in a wasm blob #9277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function can be used to add the custom section to a wasm blob with the runtime version in it.
bkchr
added
A0-please_review
pepyakin
approved these changes
Jul 6, 2021
client/executor/src/wasm_runtime.rs
Outdated
| transaction_version: 100, | ||
| }; | ||
|
|
||
| let embedded = sp_version::embed::to_wasm( |
There was a problem hiding this comment.
Nit: not a fan of this naming. Precisely how it looks at the call site.
|
|
||
| module.set_custom_section("runtime_apis", apis); | ||
|
|
||
| version.apis.to_mut().clear(); |
There was a problem hiding this comment.
Nit: I find this .clear a bit clumsy. It would've been great if we "taken" the version.apis via mem::take.
|
bot merge |
|
Waiting for commit status. |
|
Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
approved these changes
Jul 6, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function can be used to add the custom section to a wasm blob with
the runtime version in it.