This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Trait for deriving sovereign accounts of a pallet #8858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
gui1117
reviewed
May 19, 2021
|
|
||
| impl<T: PalletInfoAccess> PalletIntoAccount for T { | ||
| fn into_sub_account<AccountId: Default + Encode + Decode, S: Encode>(sub: S) -> AccountId { | ||
| sp_runtime::traits::AccountIdConversion::into_sub_account(&PalletId::new::<T>(), sub) |
There was a problem hiding this comment.
I think this easily go beyond 64 bit or 128 bit no ?
for the pallet "RandomnessCollectiveFlip", the pallet id is 4 + 1 + 24 byte, its type id is 4 byte. So the front part is 33 byte.
So the sub part will always be silent (or only on some runtime, depending on what is the pallet name).
Currently AccountIdConversion has some concern #8564
I think they should considered here.
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.