-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
Note: I had to run |
Also |
Burn-in looks fine. One thing that is curious is that before this PR we had little peaks to the number of libp2p tasks, presumably because of the periodic Kademlia requests. Now these peaks are gone. The same shows on the number of connections. There are still little peaks of number of connections every 10 minutes, when Kademlia requests trigger, but they are way less pronounced. Anyway, everything seems to work as intended. I think we need a Polkadot companion PR however. |
Can we repurpose paritytech/polkadot#2659 to serve as the companion? |
I have no idea who to ask for reviews 🙃 |
The Polkadot companion needs two approvals as well. EDIT: as long as I don't restart the CI check, probably no. |
bot merge |
Trying merge. |
* Update to libp2p-0.36 * Some more Cargo.lock updates.
* Update to libp2p-0.36 * Some more Cargo.lock updates.
Part of the upgrade to substrate 3.0 Updating some of the cargo dependencies that the original packages in substrate 3.0 release are no longer available. Update to libp2p-0.35.1 (paritytech#8141) Update to libp2p-0.36 (paritytech#8420) * Update to libp2p-0.36 * Some more Cargo.lock updates. Update to libp2p-0.35.1 (paritytech#8141) This commit can be dropped in future upgrades
Part of the upgrade to substrate 3.0 Updating some of the cargo dependencies that the original packages in substrate 3.0 release are no longer available. Unbreak browser test CI (paritytech#8148) Update to libp2p-0.35.1 (paritytech#8141) Update to libp2p-0.36 (paritytech#8420) * Update to libp2p-0.36 * Some more Cargo.lock updates. Update to libp2p-0.35.1 (paritytech#8141) This commit can be dropped in future upgrades
This PR updates
libp2p
to0.36
. The full changelog compared to0.35.1
can be seen here. The highlights are:"Parallel negotiation" is re-enabled for
multistream-select
([multistream-select] Re-enable 'parallel negotiation'. libp2p/rust-libp2p#1934) and takes effect when the dialer has 3 or more alternative protocols for a particular upgrade. I don't think this case actually ever happens in substrate though, so there should be no surprises.libp2p-mdns
has undergone a larger refactoring and sends queries much less aggressively (Don't poll network unnecessarily. libp2p/rust-libp2p#1977), which should be compensated for by queries sent whenever a multicast group is joined on a network interface. If there should be unforeseen issues, the query interval can now be configured and could be lowered to the previous 20 seconds.There is now a new implementation of the relay protocol, implemented in protocols/relay: Implement circuit relay specification libp2p/rust-libp2p#1838.
libp2p-dns
now uses thetrust-dns
library ([libp2p-dns] Use trust-dns-resolver (with either async-std or tokio). Remove thread pool. libp2p/rust-libp2p#1927), thereby supporting new features and configuration options as well as removing the previous background thread for performing DNS resolution viastd::net::ToSocketAddrs
. This also made it possible to implement support for/dnsaddr
addresses ([libp2p-dns] Implement/dnsaddr
resolution. libp2p/rust-libp2p#1931).Given the larger changes to the (M)DNS libraries, a burn-in may be appropriate.
polkadot companion: paritytech/polkadot#2672