Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Print bad mandatory error #6416

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Print bad mandatory error #6416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dbdcd5
Print bad mandatory error
bkchr Jun 18, 2020
2217be8
Update frame/system/src/lib.rs
bkchr Jun 18, 2020
daf7eec
Adds missing trait import
bkchr Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions frame/system/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ use sp_runtime::{
self, CheckEqual, AtLeast32Bit, Zero, SignedExtension, Lookup, LookupError,
SimpleBitOps, Hash, Member, MaybeDisplay, BadOrigin, SaturatedConversion,
MaybeSerialize, MaybeSerializeDeserialize, MaybeMallocSizeOf, StaticLookup, One, Bounded,
Dispatchable, DispatchInfoOf, PostDispatchInfoOf,
Dispatchable, DispatchInfoOf, PostDispatchInfoOf, Printable,
},
offchain::storage_lock::BlockNumberProvider,
};
Expand Down Expand Up @@ -1591,7 +1591,10 @@ impl<T: Trait + Send + Sync> SignedExtension for CheckWeight<T> where
// Since mandatory dispatched do not get validated for being overweight, we are sensitive
// to them actually being useful. Block producers are thus not allowed to include mandatory
// extrinsics that result in error.
if info.class == DispatchClass::Mandatory && result.is_err() {
if let (DispatchClass::Mandatory, Err(e)) = (info.class, result) {
"Bad mandantory".print();
e.print();

Err(InvalidTransaction::BadMandatory)?
}

Expand Down