Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Merge storage and storage_at RPCs #515

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Merge storage and storage_at RPCs #515

merged 2 commits into from
Aug 9, 2018

Conversation

tomusdrw
Copy link
Contributor

@tomusdrw tomusdrw commented Aug 8, 2018

Allows supplying blockhash as the last (optional) parameter. If it's not present we assume latest.

This allows us to merge *_at methods into regular ones. For backward compatibility I specified aliases.

CC @gavofyork any arguments against this?

@tomusdrw tomusdrw added A0-please_review Pull request needs code review. M6-rpcapi labels Aug 8, 2018
@gavofyork
Copy link
Member

lgtm!

@gavofyork gavofyork merged commit 687879c into master Aug 9, 2018
@gavofyork gavofyork deleted the td-storagequery branch August 9, 2018 08:12
dvdplm added a commit that referenced this pull request Aug 9, 2018
* master:
  README: fixed typo in docker run command (#518)
  Merge *_at methods. (#515)
  New flags to listen to all interfaces (#495)
  If contract reaches max depth, return Err (#503)
  Some networking cleanups (#504)
  Derivable Encode & Decode (#509)
  substrate: return Option in all storage related RPC methods (#510)
  Build with locked Cargo.lock on CI (#514)
  Place call data into a newly allocated pages (#502)
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
* subxt: Add integration-tests feature flag

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Guard integration tests under feature flag

Signed-off-by: Alexandru Vasile <[email protected]>

* test-runtime: Place build.rs under feature flag

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Pass `integration-tests` feature to `test-runtime`

Signed-off-by: Alexandru Vasile <[email protected]>

* CI: Use `integration-tests` feature to run all tests

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Rely on `#[cfg(feature = "integration-tests")]` for integration

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt/metadata: Manually construct test metadata

Signed-off-by: Alexandru Vasile <[email protected]>

* artifacts: Move scale binary blob to dedicated folder

Signed-off-by: Alexandru Vasile <[email protected]>

* examples: Update path to metadata blob

Signed-off-by: Alexandru Vasile <[email protected]>

* metadata: Rely on artifact metadata blob for benches

Signed-off-by: Alexandru Vasile <[email protected]>

* metadata: Remove `test-runtime` dependency

Signed-off-by: Alexandru Vasile <[email protected]>

* examples: Modify runtime path for `custom_type_derives`

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Remove tests folder

Signed-off-by: Alexandru Vasile <[email protected]>

* test-runtime: Remove `integration-tests` feature flag

Signed-off-by: Alexandru Vasile <[email protected]>

* integration-tests: Add an integration test crate for subxt

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Remove `test-runtime` dependency

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Add comment for feature flags

Signed-off-by: Alexandru Vasile <[email protected]>

* integration-tests: Trim dependencies

Signed-off-by: Alexandru Vasile <[email protected]>

* integration-tests: Move dependencies under dev

Signed-off-by: Alexandru Vasile <[email protected]>

* Revert "CI: Use `integration-tests` feature to run all tests"

This reverts commit 8e5f38ba8c633ac40420fadf58700ac402f762d4.

* integration-tests: Remove integration folder

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Fix feature flag and test comment

Signed-off-by: Alexandru Vasile <[email protected]>

* subxt: Extra feature flag comment

Signed-off-by: Alexandru Vasile <[email protected]>

* integration-tests: Move tests content under src

Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants