This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
TelemetryEndpoints must be valid MutliAddr URL #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @pscott signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
pscott
commented
Feb 26, 2020
pscott
commented
Feb 26, 2020
pscott
changed the title
added 2 commits
February 26, 2020 19:30
… 2803_check_url_when_creating_telemetry
pscott
commented
Feb 26, 2020
NikVolf
reviewed
Feb 26, 2020
tomaka
reviewed
Feb 27, 2020
pscott
added
A3-in_progress
|
Also this is technically a breaking change, so I guess we would wait for 3.0 to land it? |
|
Should we merge this one as well as #5057 into one bigger PR? Might be clearer? |
added 2 commits
February 28, 2020 11:47
… 2803_check_url_when_creating_telemetry
… 2803_check_url_when_creating_telemetry
|
Tests are failing on CI but they succeeded locally on my machine. Last commits that got merged to master were failing CI too.. Not sure what the protocol is in this situation... :) |
pscott
added
A0-please_review
added 2 commits
March 17, 2020 12:19
…eck_url_when_creating_telemetry
…eck_url_when_creating_telemetry
gnunicorn
changed the title
gnunicorn
changed the title
gnunicorn
approved these changes
Mar 25, 2020
gnunicorn
added
A6-mustntgrumble
and removed
A0-please_review
bkchr
approved these changes
Mar 25, 2020
|
polkadot PR paritytech/polkadot#941 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when creating a telemetry endpoint we would not verify the validity of the provided URL. If we the URL was invalid, we would just throw a
warning!, saying that the URL was invalid.With this PR, we move this parsing logic to the creation of the
TelemetryEndpointsstruct.