Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

WIP: prometheus exporter in substrate #4505

Closed
wants to merge 19 commits into from
Closed

WIP: prometheus exporter in substrate #4505

wants to merge 19 commits into from

Conversation

nodebreaker0-0
Copy link
Contributor

We are B-Harvest working on w3f granted project(https://github.com/w3f/Web3-collaboration/blob/master/grants/speculative/substrate%20x%20(prometheus%20%2B%20grafana)%20by%20B-Harvest.md). This PR is a draft implementation to request a review to be merged from parity team. We will do necessary modification if raised.

Please refer to README.md for detailed function information.

@parity-cla-bot
Copy link

It looks like @nodebreaker0-0 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@kianenigma
Copy link
Contributor

For future review, would you please:
1- rethink the title
2- mention if the PR is ready to review or WIP, via a label?

Thanks

@nodebreaker0-0 nodebreaker0-0 changed the title Master B-Harvest working on w3f granted project(Grafana) Dec 27, 2019
@nodebreaker0-0 nodebreaker0-0 changed the title B-Harvest working on w3f granted project(Grafana) prometheus exporter in substrate Dec 27, 2019
@nodebreaker0-0 nodebreaker0-0 changed the title prometheus exporter in substrate WIP: prometheus exporter in substrate Dec 27, 2019
@nodebreaker0-0 nodebreaker0-0 changed the title WIP: prometheus exporter in substrate R4R: prometheus exporter in substrate Dec 27, 2019
@nodebreaker0-0 nodebreaker0-0 changed the title R4R: prometheus exporter in substrate WIP: prometheus exporter in substrate Dec 27, 2019
@nodebreaker0-0
Copy link
Contributor Author

For future review, would you please:
1- rethink the title
2- mention if the PR is ready to review or WIP, via a label?

Thanks

Do I need to transfer the proteheus module to the utils folder?
Client module seems to have turned into Wasmbuild-target after I started developing it.

@bkchr bkchr added the A3-in_progress Pull request is in progress. No review needed at this stage. label Dec 28, 2019
@bkchr
Copy link
Member

bkchr commented Dec 28, 2019

As grafana is also in utils, it sounds like a good idea to move it to this folder.

TriplEight and others added 15 commits December 28, 2019 17:00
@TriplEight @bkchr
less dupes, cleanup (paritytech#4491)
d1012cd 
* build node job is separated from build substrate; less dupes, cleanup

* it's not effective yet to split these jobs
@bkchr
Fix cli for structopt 0.3.7 and pin to that version (paritytech#4509)
43ee8a3 
* Fix cli for structopt 0.3.7 and pin to that version

This is just some hotfix to make everything compile. In the future it
will require another pr to not depend on internals of StructOpt, but
that will probably also require some additions to StructOpt itself. To
not break the code again with another StructOpt, this also pins the
StructOpt version.

* Fix benches

* Fix for fix
@bkchr
Make wasm-builder remove invalid members (paritytech#4510)
dacb199 
* Make wasm-builder remove invalid members

Wasm-builder now removes members that point to packages that do not
exist anymore or that were renamed. Up to now, the build would fail and
required manual fixing.

* Fixes build
@nodebreaker0-0
Refactor rebase master prometheus_v0.3
9044da2
@nodebreaker0-0
Milestone1: Final Version of v0.3
6c3137b
@nodebreaker0-0
Refactor: Change module location(client ->utils)
eabd956
@nodebreaker0-0
Refactor rebase master prometheus_v0.3
44c492d
@nodebreaker0-0
Milestone1: Final Version of v0.3
7c76140
@nodebreaker0-0
Cargo.lock edit
963cbbb
@nodebreaker0-0
Cargo.toml members prometheus edit
d7a8125
@nodebreaker0-0
Cargo.toml dependency prometheus edit
74789b8
@nodebreaker0-0
chore: builder.rs edit
8f010c3
@nodebreaker0-0
Cargo.toml members prometheus edit
db10409
@nodebreaker0-0
Merge branch 'master' of https://github.com/nodebreaker0-0/substrate
a1adbca
@nodebreaker0-0
Cargo.lock rebase
bf9991f
@nodebreaker0-0 nodebreaker0-0 deleted the master branch December 30, 2019 05:13
@nodebreaker0-0 nodebreaker0-0 mentioned this pull request Dec 30, 2019
Closed
@nodebreaker0-0
Copy link
Contributor Author

#4511

original brunch, PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-in_progress Pull request is in progress. No review needed at this stage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodebreaker0-0 @parity-cla-bot @kianenigma @bkchr @NikVolf @TriplEight